Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the cursor position #89

Open
C0D3D3V opened this issue Jan 12, 2023 · 0 comments
Open

Fix for the cursor position #89

C0D3D3V opened this issue Jan 12, 2023 · 0 comments

Comments

@C0D3D3V
Copy link

C0D3D3V commented Jan 12, 2023

A bug to solve for the future maintainer :)

The position of the cursor is kind of wrong calculated.

await moveCursor(page,
action.value[0] * currentImage.width,
action.value[1] * currentImage.height
)

It should be more like this:

https://github.com/bigbluebutton/bbb-playback/blob/ba7e67d8c352d6a5383cc42442178a880db10da7/src/components/presentation/cursor.js#L18-L19

pos_X = current_view_box.x + (action.x * current_view_box.width),
pos_Y = current_view_box.y + (action.y * current_view_box.height),

At least bbb and my bbb-dl uses this calculation, and they look correct.

I also want to point out, that bbb finally published there own script to render the presentation video (without deskshare/webcams) https://github.com/bigbluebutton/bbb-presentation-video. Maybe this can be useful for the future maintainer :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant