Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a text chat #36

Open
archidn opened this issue Nov 5, 2020 · 7 comments
Open

Saving a text chat #36

archidn opened this issue Nov 5, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@archidn
Copy link

archidn commented Nov 5, 2020

Dear Tilman!
[offtopic]
Thanks again for the great and quick work done.
There is still a little more to catch up with the built-in player.
What matters is that users will involuntarily compare the built-in player and the saved file.
[/offtopic]
If you will have time, please include text chat in video.

@christmart
Copy link

This is a privacy issue. We are not allowed to have usernames in the download-video. I am not shure if it is ok to have the chat without the names. If you include the chat please make it optional.

@archidn
Copy link
Author

archidn commented Nov 5, 2020

But on the other hand, people's faces and speech are no less confidential ...
Perhaps it is possible to at least somehow shorten these names and still include the chat in the file?

@tilmanmoser
Copy link
Owner

I'm not planning to implement this anytime soon. The script is in stabilization phase, once it runs properly I may add additional features like chapter marks, polls and chat. And yes, before that I'll make all features configurable. For example not rendering zooms and cursors would speed up the rendering a lot and some don't need it.

@archidn
Copy link
Author

archidn commented Nov 6, 2020

And what do you think about our privacy discussion?

@tilmanmoser
Copy link
Owner

I already said that it would be optional. What‘s your point? This script renders only information that is publically availabe to everyone that knows the url of the published media.

@archidn
Copy link
Author

archidn commented Nov 6, 2020

Generally I meant herein proposings about removing or shortening names from chat...
But if whole chat will be optional, it is not so important.

@tilmanmoser
Copy link
Owner

I'll consider this, when I have time to integrate new functions. Honestly - I'm happy the script is working well now (as tested by @ichdasich with a huge amount of lengthy records -- thanks again). What started as a weekend project took way to much of my rare free time. Sorry to say, but new features will take some time now...

@tilmanmoser tilmanmoser added the enhancement New feature or request label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants