Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YM2610 ADPCM-A/B sample padding is incorrect #1910

Open
TheHpman opened this issue May 26, 2024 · 1 comment
Open

YM2610 ADPCM-A/B sample padding is incorrect #1910

TheHpman opened this issue May 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TheHpman
Copy link

There is an issue with the way samples are padded to fit the 256 bytes boundaries restriction.

Currently, samples are encoded and stored in ROM data, the data is then padded with 0x00 to the next 0x100 boundary. This produces incorrect data at the end of the sample, albeit for a very small time period:
image

Samples should be extended to the correct size prior to encoding to produce correct padding up to the next boundary in ROM data.

@tildearrow tildearrow added the bug Something isn't working label May 27, 2024
@TheHpman
Copy link
Author

TheHpman commented May 27, 2024

I need to add this is from the Neo Seaside NG sample track coming with Furnace, pictured data is ADPCM-B data block from VGM export (after assigning each sample to the correct region, as track puts them in both A & B by default; So basically B region only has that one sample).

Also that sample actually ends @0x1a5ff, so reported issue is still valid but only in range 0x1a5fb - 0x1a5ff unlike pictured.
However this shows us data banks have extra 256bytes of unused blank data added at their end. (0x1a600-0x1a6ff here, found that extra block in A and B regions)

So this is the actual issue, sorry for the confusion:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants