fix alignment issue in collector and validate #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangKeao
force-pushed
the
fix-232
branch
6 times, most recently
from
f6ac011 to
a6365ec
Compare
Signed-off-by: Yang Keao <[email protected]>
YangKeao
commented
Nov 7, 2024
| - Fix the alignment of the collector and validate function (#255) | ||
|
|
||
| ### Changed | ||
| - Bump the MSRV to 1.66.0 (#255) |
There was a problem hiding this comment.
Bump the MSRV to allow using AVec. The dependency aligned-vec -> equator-macro requires the feature from new version.
|
/cc @Connor1996 |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #250
close #232
This PR used
AVecto create an aligned vector. As the size of the whole file is predictable, it's still easy to read it.The
flush_nrelated logic comes from #241. This PR is easier to understand.