Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-ctl should show the timestamps in a consistent way #4730

Open
coderplay opened this issue Mar 15, 2022 · 2 comments
Open

PD-ctl should show the timestamps in a consistent way #4730

coderplay opened this issue Mar 15, 2022 · 2 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@coderplay
Copy link

coderplay commented Mar 15, 2022

When we call pd-ctl store , it shows the timestamps in 4 different ways, see below example:

    {
      "store": {
...
        "git_hash": "6c1424706f3d5885faa668233f34c9f178302f36",
        "start_timestamp": 1647365006,                                              <=========  10 digits unix timestamp
...
        "last_heartbeat": 1647373317633963588,                              <========= 19 digits unix timestamp
        "state_name": "Up"
      },
      "status": {
....
        "start_ts": "2022-03-15T17:23:26Z",                                        <========= YYYY-MM-DDTHH:mm:ss
        "last_heartbeat_ts": "2022-03-15T19:41:57.633963588Z",   <========= YYYY-MM-DDTHH:mm:ss:nnnnnnnnn
...
      }
    }

It's pretty hard to evaluate the difference between unix timestamps and the date time format. Please \ show the timestamps in a consistent way.

@coderplay coderplay added the type/enhancement The issue or PR belongs to an enhancement. label Mar 15, 2022
@rleungx
Copy link
Member

rleungx commented Mar 16, 2022

Thanks for your feedback but considering the compatibility problems, we will try to make them consistent in API version 2.

@nolouch
Copy link
Contributor

nolouch commented Mar 16, 2022

ref tikv/rfcs#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants