From bfe517a69aee8f42332004c72bc89d91f0de8035 Mon Sep 17 00:00:00 2001
From: Ville Juven <ville.juven@unikie.com>
Date: Wed, 15 May 2024 11:49:33 +0300
Subject: [PATCH] cpuload.cpp: Add PID hash function to find task structure

Adds a hash function from process PID to store and find corresponding
task info structure, instead of looping through the list.

This reduces complexity from O(n) to O(1) when calling sched_note_
functions, greatly reducing CPU load when there are a lot of processes
and context switches.
---
 platforms/nuttx/src/px4/common/cpuload.cpp | 121 +++++++++++++++++++--
 1 file changed, 111 insertions(+), 10 deletions(-)

diff --git a/platforms/nuttx/src/px4/common/cpuload.cpp b/platforms/nuttx/src/px4/common/cpuload.cpp
index 38f78997884e..0df000c4b7cd 100644
--- a/platforms/nuttx/src/px4/common/cpuload.cpp
+++ b/platforms/nuttx/src/px4/common/cpuload.cpp
@@ -51,6 +51,100 @@ __BEGIN_DECLS
 
 __EXPORT struct system_load_s system_load;
 
+/* Simple hashing via PID; shamelessly ripped from NuttX scheduler. All rights
+ * and credit belong to whomever authored this logic.
+ */
+
+#define HASH(i) ((i) & (hashtab_size - 1))
+
+struct system_load_taskinfo_s **hashtab;
+volatile int hashtab_size;
+
+void init_task_hash(void)
+{
+    hashtab_size = 4;
+    hashtab = (struct system_load_taskinfo_s **)kmm_zalloc(sizeof(*hashtab) * hashtab_size);
+}
+
+static struct system_load_taskinfo_s *get_task_info(pid_t pid)
+{
+    struct system_load_taskinfo_s *ret = NULL;
+    irqstate_t flags = enter_critical_section();
+
+    if (hashtab) {
+        ret = hashtab[HASH(pid)];
+    }
+
+    leave_critical_section(flags);
+    return ret;
+}
+
+static void drop_task_info(pid_t pid)
+{
+    irqstate_t flags = enter_critical_section();
+    hashtab[HASH(pid)] = NULL;
+    leave_critical_section(flags);
+}
+
+static int hash_task_info(struct system_load_taskinfo_s *task_info, pid_t pid)
+{
+    struct system_load_taskinfo_s **newtab;
+    void *temp;
+    int hash;
+    int i;
+
+    /* Use critical section to protect the hash table */
+
+    irqstate_t flags = enter_critical_section();
+
+    /* Keep trying until we get it or run out of memory */
+
+    retry:
+
+    /* Calculate hash */
+
+    hash = HASH(pid);
+
+    /* Check if the entry is available */
+
+    if (hashtab[hash] == NULL) {
+        hashtab[hash] = task_info;
+        leave_critical_section(flags);
+        return OK;
+    }
+
+    /* No can do, double the size of the hash table */
+
+    newtab = (struct system_load_taskinfo_s **)kmm_zalloc(hashtab_size * 2 * sizeof(*newtab));
+    if (newtab == NULL) {
+        leave_critical_section(flags);
+        return -ENOMEM;
+    }
+
+    hashtab_size *= 2;
+
+    /* Start using the new hash table */
+
+    for (i = 0; i < hashtab_size / 2; i++) {
+        struct system_load_taskinfo_s *info = hashtab[i];
+        if (info && info->tcb) {
+            hash = HASH(info->tcb->pid);
+            newtab[hash] = hashtab[i];
+
+        } else {
+            newtab[i] = NULL;
+        }
+    }
+
+    temp = hashtab;
+    hashtab = newtab;
+    kmm_free(temp);
+
+    /* Try again */
+
+    goto retry;
+}
+
 #if defined(CONFIG_SEGGER_SYSVIEW)
 #  include <nuttx/note/note_sysview.h>
 #  ifndef CONFIG_SEGGER_SYSVIEW_PREFIX
@@ -87,6 +181,10 @@ void cpuload_monitor_stop()
 
 void cpuload_initialize_once()
 {
+	/* Initialize hashing */
+
+	init_task_hash();
+
 	for (auto &task : system_load.tasks) {
 		task.valid = false;
 	}
@@ -127,6 +225,8 @@ void sched_note_start(FAR struct tcb_s *tcb)
 				task.tcb = tcb;
 				task.valid = true;
 				system_load.total_count++;
+				// add to the hashlist
+				hash_task_info(&task, tcb->pid);
 				break;
 			}
 		}
@@ -148,6 +248,8 @@ void sched_note_stop(FAR struct tcb_s *tcb)
 				task.curr_start_time = 0;
 				task.tcb = nullptr;
 				system_load.total_count--;
+				// drop from the tasklist
+				drop_task_info(tcb->pid);
 				break;
 			}
 		}
@@ -171,13 +273,12 @@ void sched_note_suspend(FAR struct tcb_s *tcb)
 			}
 		}
 
-		for (auto &task : system_load.tasks) {
+		struct system_load_taskinfo_s * task = get_task_info(tcb->pid);
+		if (task) {
 			// Task ending its current scheduling run
-			if (task.valid && (task.curr_start_time > 0)
-			    && task.tcb && task.tcb->pid == tcb->pid) {
-
-				task.total_runtime += hrt_elapsed_time(&task.curr_start_time);
-				break;
+			if (task->valid && (task->curr_start_time > 0)
+			    && task->tcb && task->tcb->pid == tcb->pid) {
+				task->total_runtime += hrt_elapsed_time(&task->curr_start_time);
 			}
 		}
 	}
@@ -200,12 +301,12 @@ void sched_note_resume(FAR struct tcb_s *tcb)
 			}
 		}
 
-		for (auto &task : system_load.tasks) {
-			if (task.valid && task.tcb && task.tcb->pid == tcb->pid) {
+		struct system_load_taskinfo_s * task = get_task_info(tcb->pid);
+		if (task) {
+			if (task->valid && task->tcb && task->tcb->pid == tcb->pid) {
 				// curr_start_time is accessed from an IRQ handler (in logger), so we need
 				// to make the update atomic
-				hrt_store_absolute_time(&task.curr_start_time);
-				break;
+				hrt_store_absolute_time(&task->curr_start_time);
 			}
 		}
 	}