From 46e166a70e865c11b466cf4fdd8824925e9adb07 Mon Sep 17 00:00:00 2001 From: Mark Spicer Date: Tue, 10 Jan 2023 14:59:24 -0500 Subject: [PATCH] Disable some lint warnings. (#560) This commit disables lint warnings for unsorted dictionaries and naming conventions. For dicts, the issue is there are a lot of dictionaries that are logcially sorted in code and this would rewrite all of them. For the naming, we have 2.8K naming convention violations in the community repo so it would be really hard to enforce the other linters if we didn't fix those first. --- cmd/buildifier.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/buildifier.go b/cmd/buildifier.go index 2acfd0f6b9..d8349ec791 100644 --- a/cmd/buildifier.go +++ b/cmd/buildifier.go @@ -168,11 +168,13 @@ var disabledWarnings = map[string]bool{ "function-docstring-header": true, // disables docstring warnings "function-docstring-args": true, // disables docstring warnings "function-docstring-return": true, // disables docstring warnings + "name-conventions": true, // disables naming convention warnings "native-android": true, // disables native android rules "native-cc": true, // disables native cc rules "native-java": true, // disables native java rules "native-proto": true, // disables native proto rules "native-py": true, // disables native python rules + "unsorted-dict-items": true, // disables dictionary sorting } // processFile processes a single file containing data.