Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self = this in last 2 versions on NPM #14

Open
pimdeheer opened this issue Jan 30, 2023 · 1 comment
Open

self = this in last 2 versions on NPM #14

pimdeheer opened this issue Jan 30, 2023 · 1 comment

Comments

@pimdeheer
Copy link

Hi,

In the last two published version on NPM (1.0.12 and 1.0.13) there is a line

self = this;

present in the distributed index.js file when installing with npm.
This line messes with webpack-dev-server and generally assigning to self is not recommended.

I cant find this line when looking at commits, so im not sure where it comes from. But its there in the distributed file when looking at the node-module folder.

The latest commited changes with abort f.ex are also not present in the distributed file, so maybe something is wrong in the pipeline somewhere.

Could you have a look and have this fixed?

@smartm0use
Copy link

As I could see this repository is not updated anymore. Only dist packages are.

I have forked it here: https://github.com/smartm0use/leaflet-wms-header-opt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants