Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type parameter of RequestDataValueProcessor#processFieldValue shouldn't be null #280

Open
sakuna63 opened this issue Feb 5, 2022 · 0 comments · May be fixed by #281
Open

type parameter of RequestDataValueProcessor#processFieldValue shouldn't be null #280

sakuna63 opened this issue Feb 5, 2022 · 0 comments · May be fixed by #281
Labels
needs triage

Comments

@sakuna63
Copy link

sakuna63 commented Feb 5, 2022 •
edited
Loading

SpringValueTagProcessor could pass null value as type parameter of RequestDataValueProcessor#processFieldValue although type is defined as Nonnull parameter（not annotated @Nullable）in spring-framework.

https://github.com/thymeleaf/thymeleaf-spring/blob/3.1-master/thymeleaf-spring5/src/main/java/org/thymeleaf/spring5/processor/SpringValueTagProcessor.java#L103-L106

For example, when SpringValueTagProcessor process <option value="aaa">, type will be null (because option has no type attribute).

In the scenario like above example, i think IElementTag#getElementCompleteName should be used as type value.

I'll send small PR to fix this issue later.
thaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use IElementTag#getElementCompleteName as fallback value of type sakuna63/thymeleaf-spring
1 participant
@sakuna63