Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkrc doesn't respect undotted #241

Open
xaltsc opened this issue Mar 18, 2019 · 5 comments
Open

mkrc doesn't respect undotted #241

xaltsc opened this issue Mar 18, 2019 · 5 comments
Labels

Comments

@xaltsc
Copy link

xaltsc commented Mar 18, 2019

In my .rcrc, I have UNDOTTED="folder*". When doing mkrc ~/folder/subfolder/file, it reinstalls the file in .folder/subfolder/file.

@mat-m
Copy link
Contributor

mat-m commented May 3, 2020

Fixed by #257, merged but not released.

@mike-burns mike-burns added the bug label Aug 28, 2020
@xaltsc
Copy link
Author

xaltsc commented Sep 14, 2021

Since it's been fixed apparently, is it included in the 1.3.4 release ?

@mat-m
Copy link
Contributor

mat-m commented Apr 30, 2022

Fixed in 1.3.5

@cryptorick
Copy link

cryptorick commented Jun 13, 2023

Fixed in 1.3.5

Respectfully, no. (Unless I'm doing something wrong.)

I cloned this repo last night and configured and make-installed the latest.

$ head -1 /usr/local/share/rcm/rcm.sh
VERSION="1.3.6"

Then, I repeated a test like the OP's and it failed.

$ # Like the OP, I have UNDOTTED.
$ cat ~/.rcrc
UNDOTTED="bin"

$ # Created a fresh .dotfiles directory.
$ [ -r ~/.dotfiles ] && echo "Yup" || echo "Nope"
Nope
$ mkdir ~/.dotfiles
$ [ -r ~/.dotfiles ] && echo "Yup" || echo "Nope"
Yup

$ # This is the file I want to mkrc.
$ ls -l ~/bin
total 4
-rwxr-xr-x 1 rick rick 32 Jun 13 13:39 foo.sh

$ # Checking for the existence of the spurious ~/.bin directory.
$ [ -r ~/.bin ] && echo "Yup" || echo "Nope"
Nope

$ # Let's do it!
$ mkrc ~/bin/foo.sh

$ # Should see the original now linked, right?  Nope, it's gone.
$ ls -l ~/bin
total 0

$ # Well, what about the spurious directory?  Doh!
$ [ -r ~/.bin ] && echo "Yup" || echo "Nope"
Yup
$ ls -l ~/.bin
total 0
lrwxrwxrwx 1 rick rick 31 Jun 13 13:52 foo.sh -> /home/rick/.dotfiles/bin/foo.sh

$ # The good news is that we haven't lost it.
$ ls -l ~/.dotfiles/bin
total 4
-rwxr-xr-x 1 rick rick 32 Jun 13 13:39 foo.sh

I'm currently using this post-processing work-around for now.

mv ~/.bin/* ~/bin

@cryptorick
Copy link

Addendum

In the meantime, lsrc has the correct reporting. 👍

 $ lsrc
/home/rick/bin/foo.sh:/home/rick/.dotfiles/bin/foo.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants