Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Code Signing done for Windows #2

Open
thorrak opened this issue Feb 8, 2020 · 1 comment
Open

Get Code Signing done for Windows #2

thorrak opened this issue Feb 8, 2020 · 1 comment
Labels
wontfix This will not be worked on

Comments

@thorrak
Copy link
Owner

thorrak commented Feb 8, 2020

Although the whole point of BrewFlasher is to reduce the amount of trouble people have when flashing firmware to an ESP, the lack of code signing works against this goal. Project for soon-ish (after I figure out the MacOS issue): Get the windows binaries code signed.

https://docs.microsoft.com/en-us/windows/win32/win_cert/windows-certification-portal

@thorrak
Copy link
Owner Author

thorrak commented Feb 10, 2020

Apparently, code signing requires an EV code signing certificate which costs upwards of ~$250 (possibly $180, but still) at the low end. That said, my apologies to Windows users - you're just going to have to deal with the warning message.

In case I ever decide to revisit this, pyinstaller code signing info is here: https://github.com/pyinstaller/pyinstaller/wiki/Recipe-Win-Code-Signing
Signtool documentation is here: https://docs.microsoft.com/en-us/windows/win32/seccrypto/signtool?redirectedfrom=MSDN
MSFT Desktop Application Program info is here: https://docs.microsoft.com/en-us/windows/win32/appxpkg/windows-desktop-application-program?redirectedfrom=MSDN#metadata
...and code signing cert info is here: https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/get-a-code-signing-certificate

@thorrak thorrak added the wontfix This will not be worked on label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant