(bug) Invalid query was not detected by linter nor evaluation

[AfikAtashga]

Observed behaviour

I created a rule, with several targeting queries and variations.
Query: (param eq "someValue or param eq "someValue2" or param eq "someValue3") and secondParam eq "someOtherValue"
I had a missing " which was not detected by linter.
Afterwards, I expected that when evaluation occur it'll return an error for failing to evaluate, but it's just skipped the evaluation of this specific query, and returned the default.

Expected Behavior

I expected the following behavior:

1. The linter should've fail the validation process because there was a missing "
2. Because there was an invalid query, it should've return an error, and possibly the default value - but there is a need for some sort of indication for issue.

Steps to reproduce

I created a few go tests the simulate the problem.
The attached .yaml file is passing the linter verification.
feature_flag_reproduce.zip

[thomaspoignant]

Hello @AfikAtashga and thanks for opening this issue.
As of Today the only validation made by the linter is that we have a non empty string, which I know is not enough.

The rule engine is based on nikunjy/rules and as of Today there is no real way to validate the rules.
I have open an issue to know if there is a better way to validate but for now I got no answer to it.
That being said, I think I can add the initial validation but it won't help with your problem.

When it comes to error, here we are using the defaultRule as default value.

[thomaspoignant]

I've added a basic check in the version v1.40.0, it will not solve your issue but as soon as the rule library has more checks it will works directly after the upgrade.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.