-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(change) Allow empty evaluation context for some flags. #2533
Comments
hello @thomaspoignant can i work on this |
Hi @thomaspoignant I met the same issue. |
@seunghunlee01 do you want to work on this? |
Hi @thomaspoignant , I don't know well golang and this open source. |
This is the not the easiest issue, but if you feel that you can do it your welcome. |
Thank you, I'll try this task. |
Motivation
As of today all flag evaluation are needing at least a
targetingKey
.The reason behind that is because the
targetingKey
is used to do bucketing during the flag evaluation (specially for percentage based rules)But not all flags requires bucketing, so in some cases it should be ok, not to have a bucketing key (
targetingKey
or any otherbucketingKey
).Example
A flag like this one does not require a bucketing key, so we should accept an empty evaluation context for such flag.
Requirements
targetingKey
we should not error if the flag is configured to use a differentbucketingKey
.TARGETING_KEY_MISSING
.targetingKey
, we should remove this mandatory thing and let the evaluation goes to the relay-proxy before returning any errors.This change is quite impactful and touch a lot of core components of GO Feature Flag, if you want to work on it please reach out before jumping on the implementation.
The text was updated successfully, but these errors were encountered: