Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing LocalStorage on each Request #17

Open
richard-flosi opened this issue Nov 24, 2014 · 1 comment
Open

Clearing LocalStorage on each Request #17

richard-flosi opened this issue Nov 24, 2014 · 1 comment

Comments

@richard-flosi
Copy link
Contributor

We started using LocalStorage in our app which has lead to some problems with the seoserver, particularly when we decided to change the default values we use in one of our LocalStorage models or when one url changes the values in LocalStorage which then effects another request.

I'd like to setup the seoserver to clear LocalStorage with each request. PhantomJS stores it's LocalStorage data in a file on the filesystem which is configurable via the --local-storage-path command line option (http://phantomjs.org/api/command-line.html).

I'm thinking in lib/seoserver.js:getContent when spawning the new phantomjs process a unique --local-storage-path could be generated and used for each child process, and then removed during the exit event. Starting up the server could also clear out any LocalStorage files that managed to linger around.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@richard-flosi and others