Skip to content

Commit

Permalink
Clean up of old Ethereum provider classes
Browse files Browse the repository at this point in the history
  • Loading branch information
RedRaton committed Jul 10, 2023
1 parent 26a0c60 commit 875bd7a
Show file tree
Hide file tree
Showing 14 changed files with 15 additions and 272 deletions.
4 changes: 2 additions & 2 deletions src/main/java/com/allmycoins/Main.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import com.allmycoins.balance.coinspot.CoinspotProvider;
import com.allmycoins.balance.cosmosjs.CosmosJsProviders;
import com.allmycoins.balance.cryptocom.CryptocomProvider;
import com.allmycoins.balance.ethereum.EthProvider2;
import com.allmycoins.balance.ethereum.EthProvider;
import com.allmycoins.balance.ethereum2.Eth2Provider;
import com.allmycoins.balance.harmony.HarmonyProvider;
import com.allmycoins.balance.litecoin.LitecoinProvider;
Expand Down Expand Up @@ -84,7 +84,7 @@ public static void main(String[] args) {

List<BalanceProvider> balanceProviders = new ArrayList<>();

List<BalanceProvider> staticProviders = List.of(new EthProvider2(), new BinanceProvider(),
List<BalanceProvider> staticProviders = List.of(new EthProvider(), new BinanceProvider(),
new CoinspotProvider(), new CryptocomProvider(), new MultiversXProvider(), new OkexProvider(),
new SwyftxProvider(), new HarmonyProvider(), new AlgorandProvider(), new TezosProvider(),
new BitcoinProvider(), new SolanaProvider(), new BscProvider(), new CardanoProvider(),
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

24 changes: 10 additions & 14 deletions src/main/java/com/allmycoins/balance/ethereum/EthProvider.java
Original file line number Diff line number Diff line change
@@ -1,38 +1,34 @@
package com.allmycoins.balance.ethereum;

import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.Future;
import java.util.stream.Collectors;

import com.allmycoins.balance.PublicAddressBalanceProvider;
import com.allmycoins.json.BalanceJson;
import com.allmycoins.utils.BigDecimalUtils;
import com.allmycoins.utils.FutureUtils;
import com.allmycoins.utils.RequestUtils;

public final class EthProvider implements PublicAddressBalanceProvider {

@Override
public List<BalanceJson> balance(String publicAddress) {
Future<EtherscanBalanceJson> futureEtherBalanceJson = RequestUtils
.sendRequestFuture(new EtherscanBalanceRequest(publicAddress));
Future<CovalentBalancesJson> futureAmberdataEthTokensJson = RequestUtils
.sendRequestFuture(new CovalentBalancesRequest(publicAddress));

Future<AmberdataEthTokensJson> futureAmberdataEthTokensJson = RequestUtils
.sendRequestFuture(new AmberdataEthTokensRequest(publicAddress));
CovalentBalancesJson covalentBalancesJson = FutureUtils.futureResult(futureAmberdataEthTokensJson);

BalanceJson ethBalance = BuildEtherscanBalance.build(FutureUtils.futureResult(futureEtherBalanceJson));
List<BalanceJson> amberdataEthTokensBalances = BuildAmberdataEthTokensBalances
.build(FutureUtils.futureResult(futureAmberdataEthTokensJson));
List<CovalentBalanceItemJson> list = List.of(covalentBalancesJson.getData().getItems());

List<BalanceJson> etherBalances = new ArrayList<>();
etherBalances.add(ethBalance);
etherBalances.addAll(amberdataEthTokensBalances);

return etherBalances;
return list.stream()
.map(i -> new BalanceJson(i.getContract_ticker_symbol(),
BigDecimalUtils.decimal(i.getBalance(), i.getContract_decimals()), "ETH wallet"))
.collect(Collectors.toList());
}

@Override
public String privateConfigKey() {
return "ETH_ADDRESS";
}

}
34 changes: 0 additions & 34 deletions src/main/java/com/allmycoins/balance/ethereum/EthProvider2.java

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import org.junit.jupiter.api.Test;

import com.allmycoins.PrivateConfig;
import com.allmycoins.balance.ethereum.EthProvider2;
import com.allmycoins.balance.ethereum.EthProvider;
import com.allmycoins.json.BalanceJson;

class EthereumProviderTest {
Expand All @@ -17,7 +17,7 @@ class EthereumProviderTest {
void testBalances() {
PrivateConfig.loadConfigurationFromClassLoader();

EthProvider2 ethereumProvider = new EthProvider2();
EthProvider ethereumProvider = new EthProvider();
List<BalanceJson> balance = ethereumProvider.balances();
assertTrue(balance.size() >= 1);
BalanceJson ethereumBalanceJson = balance.get(0);
Expand All @@ -31,7 +31,7 @@ void testBalances() {
void testNoBalances() {
PrivateConfig.clearConfiguration();

EthProvider2 ethereumProvider = new EthProvider2();
EthProvider ethereumProvider = new EthProvider();
List<BalanceJson> balance = ethereumProvider.balances();
assertTrue(balance.isEmpty());
}
Expand Down

0 comments on commit 875bd7a

Please sign in to comment.