You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a Channel is created down in castv2, it automatically registers an event handler on the Client. This means it's important for every created Channel to have its "close" method called when the channel owner goes away. Application.close() does this correctly for the "connection" channel. DefaultMediaReceiver creates a "media" channel, but never properly disposes of it, which means it's leaking EventEmitter subscriptions when the the Client connection is reused over and over to launch / join sessions with new receivers.
Suggestion: Add a "close" method to DefaultMediaReceiver and instruct to always call this when killing instances
You can easily reproduce the underlying issue by opening a connection (3 channels) and then launching and closing DefaultMediaReceivers on it 6 or 7 times (it'll create 2 channels but only properly dispose 1, so its leaking one channel for every instance up to the EventEmitter default warning threshold of 10).
The text was updated successfully, but these errors were encountered:
When a Channel is created down in castv2, it automatically registers an event handler on the Client. This means it's important for every created Channel to have its "close" method called when the channel owner goes away. Application.close() does this correctly for the "connection" channel. DefaultMediaReceiver creates a "media" channel, but never properly disposes of it, which means it's leaking EventEmitter subscriptions when the the Client connection is reused over and over to launch / join sessions with new receivers.
Suggestion: Add a "close" method to DefaultMediaReceiver and instruct to always call this when killing instances
https://github.com/i8beef/node-red-contrib-castv2/blob/master/lib/DefaultMediaReceiver.js#L25
You can easily reproduce the underlying issue by opening a connection (3 channels) and then launching and closing DefaultMediaReceivers on it 6 or 7 times (it'll create 2 channels but only properly dispose 1, so its leaking one channel for every instance up to the EventEmitter default warning threshold of 10).
The text was updated successfully, but these errors were encountered: