Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded logging locations #80

Open
hybby opened this issue Oct 2, 2017 · 5 comments
Open

Hard coded logging locations #80

hybby opened this issue Oct 2, 2017 · 5 comments

Comments

@hybby
Copy link

hybby commented Oct 2, 2017

Right now, logging appears not to be configurable, with the ERB file being hard-coded with the following stanzas:

logging {
    channel main_log {
        file "/var/log/named/named.log" versions 3 size 5m;
        severity info;
        print-time yes;
        print-severity yes;
        print-category yes;
    };
    category default{
        main_log;
    };
    category lame-servers {
        null;
    };
};

It would be helpful if the contents of main_log could be altered, for example, to permit logs to be sent to syslog instead of a specific log file.

@hybby
Copy link
Author

hybby commented Oct 2, 2017

I raised a PR (#81) to address my immediate use case, but I recognise that a more flexible approach might be preferred.

@nickchappell
Copy link

@hybby my PR from awhile ago may be of interest/use: #57

@hybby
Copy link
Author

hybby commented Oct 2, 2017

@nickchappell - oh, excellent! This looks great. I'll close my PR, as it looks like you spent a bit more time on making things lovely and configurable. Thanks for sharing!

I hope that @thias has time to look at and merge your PR soon, as it would be a great contribution.

@ybrock
Copy link

ybrock commented Feb 21, 2018

Please implement this. I'm afraid of the newrelic-forks version, as the commits are very old in this repo.

If logging is not configurable, could you consider at least not hardcoding the template ? This way it would be possible to specify the template to use as a parameter, without starting to make local commits to the module.

@sshipway
Copy link

I have created PR #105 which makes all the logging options configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants