Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate functionality of Enemy and Player collision events #102

Open
tigleym opened this issue Dec 29, 2020 · 0 comments
Open

Remove duplicate functionality of Enemy and Player collision events #102

tigleym opened this issue Dec 29, 2020 · 0 comments
Labels
refactoring Improvements to code/infrastructure quality
Milestone

Comments

@tigleym
Copy link
Collaborator

tigleym commented Dec 29, 2020

This issue looks at removing the duplicated logic done in https://github.com/amethyst/space_shooter_rs/blob/master/src/events/events.rs#L27-L67.

Ideally, we should have one general collision event to simplify things. Some approaches we can take here is to either pass enums values through the collision event channel, or, attach component tags to entities to identify different collision types.

This should also help us reduce amount of "A-to-B" / "B-to-A" collision systems that are present in enemy_collisions.rs and spaceship_collisions.rs.

@tigleym tigleym added the refactoring Improvements to code/infrastructure quality label Dec 29, 2020
@cdsupina cdsupina added this to the v0.1.8 "Boss" milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improvements to code/infrastructure quality
Projects
None yet
Development

No branches or pull requests

2 participants