[feature] Move avatar code to separate package #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_package Feat/signed multi giveaway package
We don't want the shell to process the wildcard in the arguments of istanbul-combine because it gives an error the error: `No matches found: "packages/*/coverage.json"` when there is no coverage at all, instead we want istanbul-combine to process it which gives 100% coverage for this case. See: https://github.com/thesandboxgame/sandbox-smart-contracts/actions/runs/5222655609/jobs/9428431470
feat: fix an error when there is no coverage report
use fully qualified name for the TrustedForwarderMock deploy
…-to-separate-package
abarbatei
requested review from
mvanmeerbeck and
atkinsonholly
and removed request for
a team
abarbatei
merged commit 32d6883
into
feat/new-avatar-contract-audit
1 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved avatar code to separate package
Also synced this branch with main as to avoid any compatibility issue before hand, that is why there are so many merges.
The audited code remains the same, it was just moved.
Almost all old raffle code (except doggies and PoC) was also ported to the new deploy and avatar projects, with tests and deployment scripts. Those 2 were moved to avatar code to be kept for legacy purpose.
avatarpackage now usesethers v6