-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create JupyterLab extension #1
Comments
Hi! Thanks for using this theme. It wouldn't be too much effort to port this as a JupyterLab extension, I recently thought about it. However, someone already created a gruvbox theme as a JupyterLab extension, using telemonian's Dracula theme as a base. So I'm not sure porting my version is worth the effort. I haven't tested Rahlir's theme but it may be great for your needs. |
The current version of Rahlir's theme is incompatible with JupyterLab v.1.x, so the installation method using
fails cryptically, but can be retraced within the logs mentioned within the error. There are currently 2 PRs to remedy this issue, of which one is more promising, because it does not fail tests. This was about one month ago and I do not know when Rahlir will find time to merge. Beyond that I see no problem in having the ability to choose between different implementations and I'd welcome it. Thanks for your time and hinting me to his repository. |
Thanks for the recap on Rahlir's theme situation. I won't be able to find time to create a JupyterLab v1 extension right now, but I guess it shouldn't be too hard using the PR you linked. |
Having just tried out Rahlir's theme I must admit to prefer yours. I'd definitely welcome a JL v1 extension port. Hope you'll find the time some day. |
Glad you like it, I'll see what I can do. |
Started working on it at #2 |
Would you be willing to put in the effort to move this project from a Stylus CSS file to an easier installation method as a JupyterLab extension? I'd welcome an easier and better automatable installation (like e.g. telemonian's Darcula theme):
Are there many changes needed for this to work?
Thanks for the nice theme port already
The text was updated successfully, but these errors were encountered: