Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support .fcidump extension #370

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jul 9, 2024

This fixes the other item in #367: adding "*.fcidump" to the list of patterns.

Summary by Sourcery

This pull request adds support for the '*.fcidump' file extension by updating the list of patterns and modifies the test to use the new extension for consistency.

  • Enhancements:
    • Added support for the '*.fcidump' file extension in the list of patterns.
  • Tests:
    • Updated test to use '*.fcidump' file extension for consistency.

Copy link
Contributor

sourcery-ai bot commented Jul 9, 2024

Reviewer's Guide by Sourcery

This pull request adds support for the .fcidump file extension by updating the list of patterns and modifying a test case to use the new extension.

File-Level Changes

Files Changes
iodata/formats/fcidump.py
iodata/test/test_fcidump.py
Added support for the .fcidump file extension by updating the pattern list and modifying the test case to use the new extension.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

deepsource-io bot commented Jul 9, 2024

Here's the code health analysis summary for commits decf6eb..73ff61a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

iodata/formats/fcidump.py Show resolved Hide resolved
iodata/test/test_fcidump.py Show resolved Hide resolved
Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tovrstra .

@tovrstra
Copy link
Member Author

tovrstra commented Jul 9, 2024

Thanks for reviewing!

@tovrstra tovrstra merged commit 4e15520 into theochem:main Jul 9, 2024
12 checks passed
@tovrstra tovrstra deleted the fcidump-pattern branch July 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants