Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless catch_warnings #353

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

tovrstra
Copy link
Member

A cleanup in the list of #191, deferred from #352
These are no longer needed, and they are also a poor practice for testing warnings in unit tests. Good riddance.

Copy link

deepsource-io bot commented Jun 28, 2024

Here's the code health analysis summary for commits 03bf3e6..b335004. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tovrstra
Copy link
Member Author

Thanks for the quick review!

@tovrstra tovrstra merged commit 8cf1132 into theochem:main Jun 28, 2024
12 checks passed
@tovrstra tovrstra deleted the drop-warning-catchall branch June 28, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants