Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment oldest scipy version because 1.11.0 is yanked #336

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 15, 2024

Minor fix. Will YOLO-merge Friday June 21 unless reviewed earlier.

Summary by Sourcery

This pull request updates the scipy version in the pytest workflow configuration from 1.11.0 to 1.11.1 due to the former being yanked.

  • Build:
    • Updated scipy version from 1.11.0 to 1.11.1 in the pytest workflow configuration.

@tovrstra tovrstra requested a review from PaulWAyers June 15, 2024 13:48
Copy link

deepsource-io bot commented Jun 15, 2024

Here's the code health analysis summary for commits 2bfbd6c..fd2f3f6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

sourcery-ai bot commented Jun 15, 2024

Reviewer's Guide by Sourcery

This pull request updates the scipy version from 1.11 to 1.11.1 in the GitHub Actions workflow file (.github/workflows/pytest.yaml) to address the yanking of version 1.11.0.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

docs/install.rst Show resolved Hide resolved
Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Toon.

@tovrstra
Copy link
Member Author

Thanks for checking. Merging...

@tovrstra tovrstra merged commit d61c2ed into theochem:main Jun 15, 2024
12 of 13 checks passed
@tovrstra tovrstra deleted the scipy-1.11.1 branch June 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants