-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic Static Dipole Polarizabilities #98
Comments
@PaulWAyers @marco-2023 @msricher ">With regards to the issue: ``During testing, I observed an issue in the code: it is loading compiled data instead of data directly from the files."
I think we knew that if the Species properties were modified one would need to recompile the databases in order to have those properties available through the Species class. To me one (dirty alternative) to the task of recompiling the neutral species though all databases would be to only recompile the NIST database given that this is the one that takes lowest disk space (since it does not include any density properties). |
Is it very painful to compile the data? I wonder if this is just something that is part of the workflow when a new species properties is added. That isn't something that is terribly problematic, and I can imagine that one may (eventually) want dipole polarizabilities at other levels of theory too. |
My thoughts at the beginning were to not compile this data at all. This data (periodic) is prone to change every few years. I think a good compromise is to just load the atomic properties once (as it is done now before compiling the data) at the moment when AtomDB is loaded and complement the data with the rest of the properties that are compiled (that should never change). In this way, the parsing of the elements data file will be done only once, and from then on, this data is accessed from memory. |
It would be good to add that feature if not yet supported. See the reference data here.
The text was updated successfully, but these errors were encountered: