Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect positive definite kinetic energy density values from Slater dataset #128

Open
gabrielasd opened this issue Nov 6, 2024 · 1 comment
Assignees

Comments

@gabrielasd
Copy link
Collaborator

It appears there is an issue with how the kinetic energy density (KED) is being evaluated in the Slater dataset compilation script.

This problem shows when comparing radial grid plots of the KED from the Slater set to those generated from the Gaussian or HCI datasets:
image

This is the function that needs revision:

def eval_ked_positive_definite(self, points):

@Ali-Tehrani
Copy link
Collaborator

Ali-Tehrani commented Nov 6, 2024

This is probably because it used the old incorrect method to calculate the kinetic energy from four years ago in BFit.
The new-updated version was added two years in BFit with tests matching the kinetic energy value obtained from the slater files.
Hope that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants