Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

?Q? add .storeAccounts global boolean? #16

Open
spencercap opened this issue May 30, 2023 · 0 comments
Open

?Q? add .storeAccounts global boolean? #16

spencercap opened this issue May 30, 2023 · 0 comments
Labels
question Further information is requested

Comments

@spencercap
Copy link
Member

spencercap commented May 30, 2023

should we add a global bool for .storeAccounts which is checked before every write to .store.activeAccount etc etc

i was going to implement this but realized there would be a tone of unintended side effects like computed vars .isConnected and .isActive and .activeWallet checks that being correct.

Screenshot 2023-05-30 at 10 49 01 PM
			if (AnyWalletState.storeAccounts == false) {
				logger.log('.storeAccounts set to false, not recalling or setting .stored');
				return;
			}
@spencercap spencercap added the question Further information is requested label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant