-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for workspaces with flowbite.content() #1497
Comments
The below line u are referring to is exactly configured to be used within a monorepo (in this very monorepo structure) where
We'll think of a better API in the future for configuring paths for monorepo structures. |
Why not have it auto-configured? Avoid shooting yourself in the foot, and guessing where the right directory is.
Eager to learn more, what did you have in mind? |
@sughodke u can't really have it "auto-configured" due to the vast ways of using and configuring monorepo's, it's almost impossible to auto detect where the package is installed, thats why we're considering to pre-compile and extract all classNames used in the package (per component too), and feed those to Also, this is why |
That's the point, we're not, we know exactly where the packages are being installed, since we configured the monorepo, so there's no "guessing". |
As the below line from this very repo shows,
flowbite.content()
returns a path assuming you are running flowbite in a standalone repo. But if you are using flowbite in monorepo, this assumption is not valid and the path returned byflowbite.content()
is incorrect. The build (vianpm run build
) works as expected, but the resultant CSS artifacts don't contain all the CSS.flowbite-react/apps/web/tailwind.config.cjs
Line 11 in bed3c41
I propose within
flowbite.content()
we userequire.resolve()
to correctly find the node_modules directory to avoid this guessing.The text was updated successfully, but these errors were encountered: