Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenoFLU] update docker to v1.05 #704

Merged
merged 2 commits into from
Dec 31, 2024
Merged

[GenoFLU] update docker to v1.05 #704

merged 2 commits into from
Dec 31, 2024

Conversation

sage-wright
Copy link
Member

@sage-wright sage-wright commented Dec 27, 2024

This PR closes #703

🗑️ This dev branch should be deleted after merging to main.

🧠 Summary

  • updates GenoFLU docker to v1.05

⚡ Impacted Workflows/Tasks

  • TheiaCoV workflows with the flu track (FASTA, ONT, PE)

This PR may lead to different results in pre-existing outputs: Yes

  • updated genoflu docker could lead to different detected genotypes

This PR uses an element that could cause duplicate runs to have different results: No

🛠️ Changes

⚙️ Algorithm

  • docker 1.03 -> 1.05

➡️ Inputs

None

⬅️ Outputs

None

🧪 Testing

Suggested Scenarios for Reviewer to Test

🔬 Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable
    • You have updated the latest version for any affected worklows in the respective workflow documentation page and for every entry in the three workflows_overview tables. I'm not doing this because it'll cause conflicts with other PRs I've made in the last week -- if those PRs get merged, there will be no conflicts and the appropriate fields will have already been updated

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@sage-wright sage-wright marked this pull request as ready for review December 27, 2024 16:14
@sage-wright sage-wright requested a review from a team as a code owner December 27, 2024 16:14
Copy link
Contributor

@Michal-Babins Michal-Babins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumps version of genoflu from 1.03 -> 1.05.

@Michal-Babins
Copy link
Contributor

Tested TheiaCov_Illumina_PE, TheiaCoV_Fasta, and TheiaCoV_ONT, where genoflu was triggered 1.05 is working as expected.

@Michal-Babins Michal-Babins merged commit ffbbe81 into main Dec 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update genoflu to v1.0.5
2 participants