hiding tables - Issue 274 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch case is implemented
…is hidden and added a test for hiding tables
…test into the existing test for RabbitInAHat
janblom
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Basically it worked as intended and I have no remarks on the solution, looks good to me.
I did have to repair the automatic running of tests in the rabbitinahat module, but that was something I left behind in a poor state.
I did integrate the unit test for hiding tables into the already existing TestRabbitInAHatMain test, to avoid code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for hiding tables. Users can select tables by opening a dialog where they can select tables manually or select/deselect a selection using a search bar by either using match case or regex. Related to issue OHDSI#274