Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] CSV upload of ip ranges in the admin portal #285

Open
roald-teunissen opened this issue Aug 19, 2022 · 1 comment
Open

[ENHANCEMENT] CSV upload of ip ranges in the admin portal #285

roald-teunissen opened this issue Aug 19, 2022 · 1 comment
Assignees

Comments

@roald-teunissen
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Since we have multiple importers, it would be nice to have a way to let staff manually add ip ranges or ASN to a specific hosting provider.

Describe the solution you'd like
A extra page in the admin portal where a user could upload a CSV file. This page would need the following:

  • A dropdown for choosing a hosting provider
  • A area to drop a CSV file in, which adheres to a certain structure that is specified
  • A check or toggle box specifying if this import should declare all other ranges as inactive or not

Describe alternatives you've considered
Using a command or manually uploading a CSV file to the database.

Additional context
One of our staff members has gathered some ip ranges that are suppose to be updated. In order to do this fast, this staff member suggested to the dev team to update the database. In further thought, we decided to make a functionality for staff members so they can do it manually.

@mrchrisadams
Copy link
Member

hey @roald-teunissen There are two ways we could do this, based on our earlier description.

1. Add it as a separate page
This is arguably simpler, but we need to let the user choose the provider.

We would also need to have a to mitigate against someone uploading IP ranges to the wrong provider by accident.

2. Add it on the provider page

If we do this, the actual provider to update is implicitly set. This avoids the issue, but it technically more complex as we'd be modifying the provider change page some more, and changing the django admin formsets on models can be a bit daunting.

The good news is that in an earlier PR, #188, we had some of this logic implemented already, for us to refer to.

#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants