configure tftp root folder for RHEL8 #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Mar 25, 2021
| @@ -12,6 +12,26 @@ | |||
| changes => "set tftpd_flags '\"-s ${tftp::root}\"'", | |||
| } | |||
| } | |||
| if $facts['os']['family'] =~ /^(RedHat)$/ { | |||
| if versioncmp($facts['os']['release']['major'], '8') == 0 { | |||
| systemd::unit_file { 'tftp.service': | |||
There was a problem hiding this comment.
I think it would be much better to use a drop in instead that just replaces ExecStart. Something like:
include systemd
systemd::dropin_file { 'root-directory':
unit => 'tftp.service',
content => "[Service]\nExecStart=\nExecStart=/usr/sbin/in.tftpd -s ${tftp::root}\n",
}
# Deal with both camptocamp/systemd < 3
if defined(Class['systemd::systemctl::daemon_reload']) {
Systemd::Dropin_file['root-directory'] ~> Class['systemd::systemctl::daemon_reload'] -> Service[$ftp::service]
}| @@ -12,6 +12,26 @@ | |||
| changes => "set tftpd_flags '\"-s ${tftp::root}\"'", | |||
| } | |||
| } | |||
| if $facts['os']['family'] =~ /^(RedHat)$/ { | |||
| if versioncmp($facts['os']['release']['major'], '8') == 0 { | |||
There was a problem hiding this comment.
I think it's actually safe to assume it's also true on newer versions (which may include Fedora):
Suggested change
| if versioncmp($facts['os']['release']['major'], '8') == 0 { | |
| if versioncmp($facts['os']['release']['major'], '8') >= 0 { |
Comment on lines
14
to
+15
| } | ||
| if $facts['os']['family'] =~ /^(RedHat)$/ { |
There was a problem hiding this comment.
Suggested change
| } | |
| if $facts['os']['family'] =~ /^(RedHat)$/ { | |
| } elsif $facts['os']['family'] == 'RedHat' { |
|
Included in #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When daemon true in RedHat family greater then 8, the tftpd service is started with the default root folder.
Require: systemd: 'https://github.com/camptocamp/puppet-systemd'