Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchecking checkboxes no longer clear values in latest javascript changes #365

Open
btoneill opened this issue Oct 15, 2024 · 0 comments
Open

Comments

@btoneill
Copy link

Describe the bug
When you check a checkbox to do something like enable NUMA, it works fine.
When you uncheck a checkbox to do something like disabled a checked NUMA box, it ignores it.

To Reproduce
Steps to reproduce the behavior:
Check box, update, verify on proxmox
Uncheck box, update, verify on proxmox

Expected behavior
Unchecking box should disable the option

Additional context
I ran into this issue when adding an option for enabling/disabling backups. I found it is something in the javascript framework that is not passing an unchecked value to the HTTP POST, it is just leaving it blank. I'm not familiar with javascript to know if it's a problem with the framework itself or the implementation of it. I got around the issue in my PR for this by switching to using a Enabled/Disabled pull down menu option instead of a checkbox. It appears to affect any checkboxes that you attempt to uncheck with the Virtual Machine setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant