Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid data for GB #34

Open
lucabob opened this issue Jun 12, 2018 · 1 comment
Open

Invalid data for GB #34

lucabob opened this issue Jun 12, 2018 · 1 comment

Comments

@lucabob
Copy link

lucabob commented Jun 12, 2018

This gem returns completely invalid data for GB:

irb(main):001:0> CS.get(:gb)
{:ENG=>"England",
 :KEN=>"Kent",
 :LND=>"City of London",
 :NIR=>"Northern Ireland",
 :SCT=>"Scotland",
 :SOM=>"Somerset",
 :SRY=>"Surrey",
 :WLS=>"Wales"}

It returns a mixture of counties, local government, countries and provinces. It should probably refer to ISO 3166-2:GB, and return the codes for what that considers countries and provinces.

@hemaldev
Copy link

hemaldev commented Sep 8, 2018

Have just come across this gem, shame it doesn't seem to be maintained. I ran CS.update and CS.get(:gb) and got

{:ENG=>"England", :NIR=>"Northern Ireland", :SCT=>"Scotland", :WLS=>"Wales"}

Perhaps CS.update did the trick...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants