System.Net.Websockets

[yallie]

Hello!

Any particular reason why CoreRemoting uses websocket-sharp?
As far as I know, .NET framework has its own websocket implementation
https://learn.microsoft.com/en-us/dotnet/api/system.net.websockets

Why can't we use it to get rid of external dependencies?

Third party websocket implementations like websocket-sharp and fleck
don't seem to be maintained as far as I can see...

Websocket-sharp code base looks like it has some activity, but all commits
seem to be autogenerated by a tool, which is pretty suspicious :)

https://github.com/sta/websocket-sharp/commits/master/

[theRainbird]

Hi!

Any particular reason why CoreRemoting uses websocket-sharp?

System.Net.Websockets is very low level, especially at server side.
So I don't wanted to reinvent the wheel. Same with WatsonTCP.
Implementing a performant and reliable Websocket or TCP server, that runs well on Windows and Linux and also with .NET Framework 4.8 / Mono and .NET 5+, is not an easy task.

Why can't we use it to get rid of external dependencies?

Yes, we can use it. Lesser external dependencies are always better.
As far as I know, there are two options, implementing a server with System.Net.Websockets:

• Using HttpListener
• Using the ASP.NET (Core) stack

HttpListener would be the more lightweight way with a lot of handwork to do.
The ASP.NET (Core) stack itself is a big dependency, but is a ready to use and would be easier to get in a reliable state.
But there are many differences in ASP.NET with .NET Framework 4.8 and ASP.NET Core.
This could be also be a lot of work.

Websocket-sharp code base looks like it has some activity, but all commits
seem to be autogenerated by a tool, which is pretty suspicious :)

Looks creepy.

[yallie]

System.Net.Websockets is very low level, especially at server side.
So I don't wanted to reinvent the wheel. Same with WatsonTCP.

Oh, I see... I was unaware that HttpListener support for websockets is so incomplete.
Now it makes sense why is there so many third party websocket implementations for .NET.