Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about quic printer #959

Open
fxlb opened this issue Nov 17, 2021 · 5 comments · May be fixed by #960
Open

Question about quic printer #959

fxlb opened this issue Nov 17, 2021 · 5 comments · May be fixed by #960

Comments

@fxlb
Copy link
Member

fxlb commented Nov 17, 2021 •
edited
Loading

@rpaulo
With the attached pcap, tcpdump prints:

$ ./tcpdump -#nv -r merge-request-268-q46_ack.pcapng
reading from file ../pcap-files/wireshark-menagerie/merge-request-268-q46_ack.pcapng, link-type EN10MB (Ethernet), snapshot length 65535
    1  15:15:25.415546 IP (tos 0x0, ttl 63, id 3862, offset 0, flags [DF], proto UDP (17), length 1378)
    185.217.151.45.27940 > 134.148.213.244.443: quic, initial, v51303436, length 3029401132267995136 [|quic]

length 3029401132267995136, really?
tshark shows it as GQUIC, You should have a look.

merge-request-268-q46_ack.pcapng.gz
@rpaulo
Copy link
Contributor

rpaulo commented Nov 17, 2021

The printer doesn’t support Google QUIC packets, only IETF QUIC.

@fxlb
Copy link
Member Author

fxlb commented Nov 17, 2021 •
edited
Loading

Thus, it should display unsupported for such packets.

@fxlb
Copy link
Member Author

fxlb commented Nov 17, 2021 •
edited
Loading

Or gquic (unsupported) ...

@rpaulo
Copy link
Contributor

rpaulo commented Nov 17, 2021

Okay, but I wonder if it's worth the effort since in the near future the Google QUIC packet format will go away.

@fxlb
Copy link
Member Author

fxlb commented Nov 17, 2021

We just don't want print incorrect informations.

rpaulo pushed a commit to rpaulo/tcpdump that referenced this issue Nov 17, 2021
Don't try to print any information about gQUIC packets.
abadcc0 
Fixes the-tcpdump-group#959.
@rpaulo rpaulo linked a pull request Nov 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't try to print any information about gQUIC packets. rpaulo/tcpdump
2 participants
@rpaulo @fxlb