Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opportunity/complication icons appearing when they shouldn't with advantage/disadvantage #125

Closed
chibirobin opened this issue Oct 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@chibirobin
Copy link

When messing around with attack rolls with advantage and disadvantage, if you get the highest/lowest number on the discarded die the result will still display it as an opportunity or a complication.

  1. Make an attack roll with advantage or disadvantage.
  2. If the roll will keep highest, get the other die to roll a 1. If the roll will keep lowest get the other die to be a 20.

I would expect if the result is not a critical fail or success to not display an opportunity or complication.

weufbwkefbwkefjb
Screenshot 2024-10-28 210422

Version
0.1.1

@chibirobin chibirobin added the bug Something isn't working label Oct 28, 2024
@zithith
Copy link
Collaborator

zithith commented Nov 13, 2024

Consider waiting on #107 ?

@MangoFVTT
Copy link
Collaborator

This is fixed by the styling ticket since chat cards now properly show both dice in an advantage/disadvantage roll, so the complications/opportunities will appropriately be faded out if they belong to the dice that caused them.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants