Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ancestry item sheet #12

Closed
stanavdb opened this issue Aug 13, 2024 · 2 comments
Closed

Add ancestry item sheet #12

stanavdb opened this issue Aug 13, 2024 · 2 comments
Assignees
Labels
feature request New feature ui User interface related issue ux User experience related issue
Milestone

Comments

@stanavdb
Copy link
Collaborator

We need to add an ancestry item sheet

Note: The ancestry item data model does not yet have advancements set up. This can be left out for the time being.

@stanavdb stanavdb added ui User interface related issue ux User experience related issue feature request New feature labels Aug 13, 2024
@stanavdb stanavdb added this to the Release 0.1.0 milestone Aug 13, 2024
@zithith
Copy link
Collaborator

zithith commented Aug 28, 2024

#34

zithith added a commit to zithith/cosmere-rpg that referenced this issue Sep 2, 2024
zithith added a commit to zithith/cosmere-rpg that referenced this issue Sep 2, 2024
zithith added a commit to zithith/cosmere-rpg that referenced this issue Sep 4, 2024
@stanavdb stanavdb assigned stanavdb and zithith and unassigned stanavdb Sep 4, 2024
stanavdb added a commit that referenced this issue Oct 19, 2024
* chore: Fixed custom fonts

* feat(ancestry sheets): Aded basic Ancestry sheets and advancement data model. Swapped to built-in prosemirror custom element. Updated Item styling to use vertical tabs.

* feat(culture sheet): updated culture sheets to use prosemirror editor and placeholder decsriptions

* chore: minor item header style update

* chore: post merge alignment. Updated Connection, injury, loot, path & specialty items to use the prosemirror element correctly and have initial placeholder values.
Updated cultre and ancestry sheets to make use of base item's form actions.
Fixed specialty item initialisation issues.

* chore: item sheets tab styling alignment

* feat(item sheets): refactored description enrichment to base item sheets

* feat(ancestry sheets): removed custom prose-mirror component

* chore: updated armor and trait items to use description placeholders

* feat(item sheets): ancestry details tab added, with some placeholder content.

* chore: updated missed label localisation

* feat(item sheets): updated new sheet types to include description placeholders & details icons

* feat(item sheets): Ancestry details tab placeholders replaced with valid controls.

* css tweaks

* feat(item sheets): made item sheet tab display into a world setting

* feat(item sheets): style tweaks

* feat: add document ref input component

* feat(ancestry sheet): improve usability of advancement extra talents list

* feat(ancestry sheet): replace talent picks list with bonus talents rules list

* feat(ancestry-sheets): PR comments addressed:
- removed orphaned & redundant code
- small caps applied to headers
- font changes restricted to document sheets for now
- hid the item titles when sheets not minimised
- description tab only shows editor if the sheet is editable for the user

* feat(item sheets): updated description tab to display read-only elements in a column

---------

Co-authored-by: stanavdb <[email protected]>
@stanavdb
Copy link
Collaborator Author

Closed with #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature ui User interface related issue ux User experience related issue
Projects
None yet
Development

No branches or pull requests

2 participants