-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: api 연결 #15
Merged
Merged
feat: api 연결 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOdiO89
force-pushed
the
#12-Feature/API
branch
from
September 1, 2024 17:38
9962292
to
539d2f7
Compare
iOdiO89
force-pushed
the
#12-Feature/API
branch
from
September 1, 2024 17:42
539d2f7
to
8446b03
Compare
효과음 발생 관련하여서, 승인대기 중인 주문이 존재한다면 계속 효과음 발생으로 수정 부탁드립니다! (GET 했을 때 승인대기 주문이 있다면 그냥 계속 효과음 발생) PATCH api 관련해서는
이 문제가 되는 상황인거죠? |
DeveloperRyou
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드는 좋은것 같습니다.
다만, 한 pr에 많은 커밋이 있어서 디테일하게 확인하기는 어려웠어요!
쪼개서 올려주시면 다음에는 더 좋을것 같습니다~
|
iOdiO89
force-pushed
the
#12-Feature/API
branch
from
September 3, 2024 04:07
943b293
to
5e81f49
Compare
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
정렬이랑 탭별로 출력해야 하는 기준들이 조금씩 달라서 정리했습니다!
의도랑 구현한 거랑 일치하는지 위주로 봐주시면 좋을 것 같습니다
승인대기
ㄴ 이전 fetch의 승인대기탭 order count < 현재 fetch의 order count 일 때, 효과음 발생
ㄴ 새로 로그인해서 들어왔을 때 승인대기 중인 주문이 존재한다면 효과음 발생
진행 중
히스토리
api notice
추가)
주문 승인 되었을 때 사라지는 애니메이션 같은 게 필요할까요? 승인대기 버튼 눌렀을 때 아무런 문구 없이 바로 승인대기탭에서 사라지니까 원하는 주문이 제대로 승인되었는지 알기 어려운 것 같습니다.