Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 #540

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

v1 #540

wants to merge 12 commits into from

Conversation

enisdenjo
Copy link
Member

@enisdenjo enisdenjo commented Jul 26, 2024

Defining the package manager manually is no longer necessary, we should (and mostly do) use the "packageManager" property in package.json and rely on corepack to handle the rest.

Additionally, we should also rely on .node-version to consistently use the same version locally (with nvm or fnm) like in the CI (this needs to be migrated, but the option is there).

Also refactor to use kebab-case for variable names in the setup workflow.

Breaking Changes

  • "packageManager" must be defined in the project
    • Setup packageManager input dropped
    • Setup packageManagerVersion input dropped
  • nodeVersion input changed to node-version
  • workingDirectory input changed to working-directory
  • changesets-dependencies.yaml renamed to .github/workflows/changesets-dependencies.yml (no "a" in extension)
  • setupEnvWorkingDirectory input changed to setup-working-directory
  • Workflows run on ubuntu-latest
  • release-snapshot.yml has no default buildScript
    • sometimes a package can just have a "prepack/prepublish" script that will run before publishing

TODO

Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: e8d3798

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 26, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/prettier-config 2.0.7-alpha-20240726125731-6ff87cd045d5e99ad563af11a544065ea2116622 npm ↗︎ unpkg ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants