Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 07th of August 2023 #6581

Merged
merged 3 commits into from
Aug 7, 2023
Merged

[Release] 07th of August 2023 #6581

merged 3 commits into from
Aug 7, 2023

Conversation

waghanza
Copy link
Collaborator

@waghanza waghanza commented Aug 6, 2023

@itsumura-h I have a compilation issue for basolato (with nim2)

command line(1, 2) Warning: `gc:option` is deprecated; use `mm:option` instead [Deprecated]
Hint: used config file '/nim/config/nim.cfg' [Conf]
Hint: used config file '/nim/config/config.nims' [Conf]
Hint: used config file '/usr/src/app/config.nims' [Conf]
.......................................................................................................................................................
/root/.nimble/pkgs2/basolato-0.14.1-94cac86836d620bbef281bc9886476b9677502ff/basolato/core/header.nim(56, 11) Warning: a, b all have default value 'newHttpHeaders(true)', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue]
.....
/root/.nimble/pkgs2/basolato-0.14.1-94cac86836d620bbef281bc9886476b9677502ff/basolato/core/logger.nim(3, 11) Warning: imported and not used: 'terminal' [UnusedImport]
...................
/root/.nimble/pkgs2/basolato-0.14.1-94cac86836d620bbef281bc9886476b9677502ff/basolato/core/security/session_db/file_session_db.nim(37, 59) template/generic instantiation of `async` from here
/root/.nimble/pkgs2/basolato-0.14.1-94cac86836d620bbef281bc9886476b9677502ff/basolato/core/security/session_db/file_session_db.nim(38, 51) template/generic instantiation of `>` from here
/root/.nimble/pkgs2/flatdb-0.2.6-23eea36f78fd60d6798f8c32ccb85e91bfd1e356/flatdb.nim(271, 15) Error: type mismatch: got 'proc (x: JsonNode): bool{.closure, noSideEffect, gcsafe.}' for 'proc (x: JsonNode): bool = return getStr(getOrDefault(x, key), "") == val' but expected 'proc'

@jim-king-2000 @koplenov When this PR will be merge, results will be refreshed

Failing framowrks
  • handy
  • servernio
  • archttp
  • beetlex
  • amber

ℹ️ Failing frameworks will be hidden

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 6, 2023

@dom96 with jester I have

INFO Jester is making jokes at http://0.0.0.0:3000
Starting 4 threads
Listening on port 3000
SIGSEGV: Illegal storage access. (Attempt to read from nil?)
Segmentation fault

ℹ️ On nim 2.0

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 6, 2023

@ringabout Not sure why but prologue does not seems to listen to port 3000 anymore like expected. Could you take a look ?


With debug mode, I have

DEBUG Prologue is serving at http://0.0.0.0:3000
DEBUG Starting 8 threads
DEBUG Listening on port 3000

but curl http://127.0.0.1:3000 leads to a connexion refused

*   Trying 127.0.0.1:3000...
* connect to 127.0.0.1 port 3000 failed: Connexion refusée
* Failed to connect to 127.0.0.1 port 3000 after 0 ms: Connexion refusée
* Closing connection 0
curl: (7) Failed to connect to 127.0.0.1 port 3000 after 0 ms

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 6, 2023

@mattaylor I have a compilation error on whip

/root/.nimble/pkgs2/packedjson-0.2.2-31464998abf68abd1e9ded84a8692bc8d98c319a/packedjson.nim(325, 5) Error: undeclared identifier: 'shallowCopy'
candidates (edit distance, scope distance); see '--spellSuggest':
 (6, 6): 'alloc'
 (6, 6): 'alloc0'
 (6, 6): 'allocImpl'

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 6, 2023

@crimson-knight During amber compilation I have some warnings

Shard "inflector" version (0.1.8) doesn't match tag version (1.0.0)
Shard "micrate" version (0.14.0) doesn't match tag version (0.15.0)

When running amber, I have

Unhandled exception: Error executing process: 'amber': No such file or directory (File::NotFoundError)
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from ???
  from src/env/__libc_start_main.c:95:2 in 'libc_start_main_stage2'

Perhaps, the dockerfile is not correct

  FROM crystallang/crystal:1.9.2-alpine

WORKDIR /usr/src/app

  COPY 'config/application.cr' 'config/application.cr'
  COPY 'config/routes.cr' 'config/routes.cr'
  COPY 'src/amber.cr' 'src/amber.cr'
  COPY 'src/benchmark_amber.cr' 'src/benchmark_amber.cr'
  COPY 'src/controllers/application_controller.cr' 'src/controllers/application_controller.cr'
  COPY 'shard.yml' 'shard.yml'

RUN apk add --update yaml-static

RUN apk add --update sqlite-dev

RUN shards lock
RUN shards install --production
RUN shards build --release --no-debug --static

FROM alpine

WORKDIR /usr/bin

COPY --from=0 /usr/src/app/bin/server /usr/bin/app

  COPY 'config/environments/production.yml' 'config/environments/production.yml'


CMD /usr/bin/app

@dom96
Copy link
Contributor

dom96 commented Aug 6, 2023

@waghanza can you just keep running jester/httpbeast with old Nim?

@cyrusmsk
Copy link
Contributor

cyrusmsk commented Aug 6, 2023

@waghanza any additional info regarding handy and serverino? So I can test and fix them? Because they are passing tests. Probably problems are raising after high load..

@ringabout
Copy link

can you just keep running jester/httpbeast with old Nim?

Or might try with --mm:refc.

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 7, 2023

can you just keep running jester/httpbeast with old Nim?

if no solution is found on monday @dom96

Or might try with --mm:refc.

Seems working ❤️

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 7, 2023

@waghanza any additional info regarding handy and serverino? So I can test and fix them? Because they are passing tests. Probably problems are raising after high load..

Exactly. I have the same for archttp, that is why I prefer to open a new PR (in fact you can) to enable debug mode and try to debug together.

For archttp, I have noticed that at a certain level, the server stops (with a segfault iirc)

@waghanza waghanza merged commit 81f9946 into master Aug 7, 2023
@waghanza waghanza deleted the update branch August 7, 2023 06:25
@waghanza
Copy link
Collaborator Author

waghanza commented Aug 7, 2023

@jim-king-2000
Copy link
Contributor

Fantastic! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants