-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next steps with groupcache (galaxycache) #5037
Comments
Looking forward to the documentation. Can't wait to try it 👍 |
#5068 fixes [4] and [5]. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
From our experience, groupcache is still slow due to the last point - we need to fetch multiple keys in one request. |
Hello 👋 Looks like there was no activity on this issue for the last two months. |
Hey @GiedriusS, I would like to pick a sub-issue of this open issue which is Make pull request that pushes changes (Thanos update) back into Cortex As I am a newbie to open source contribution & Thanos codebase, can someone share some docs to help me understand the requirement better? Any acceptance criteria for this feature? Or which flow/component in the Thanos codebase should I focus on? :) |
Amazing, thanks! So cc @yeya24 @GiedriusS does it sounds right? |
Thanks for picking this up! I am personally doubtful whether it is needed to pursue this further, I might even be leaning towards deleting groupcache before 1.0 😢 as far as I understand, the problem is that we are serializing access to a single |
Got it. I think it's nice piece to work, but best effort. Still something to consider if blockers are improved. What would be a benchmark that could reproduce the problem? What requirements we are looking for in terms of efficiency here? |
After #4818 has been merged, I am writing down a list of TODO:
For implementing the last two, perhaps we could even switch to gRPC?
Maybe I have missed something?
The text was updated successfully, but these errors were encountered: