Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assumption of numeric node id #338

Open
micahscopes opened this issue Sep 15, 2022 · 1 comment
Open

assumption of numeric node id #338

micahscopes opened this issue Sep 15, 2022 · 1 comment

Comments

@micahscopes
Copy link

micahscopes commented Sep 15, 2022

I noticed that the getSourceIndex and getTargetIndex functions assume a numeric id. Why is this necessary? I've been using non-numeric id's in my project and while I could convert them all to some number, seems like it'd be nice if I didn't need to do that.

https://github.com/micahscopes/WebCola/blob/4aa06a7af9919a1dde3d79f9f0636573aa7df4fa/src/layout.ts#L781-L783

@aneziac
Copy link

aneziac commented Sep 6, 2023

Running into the same issue here. It was also hard to track down from the somewhat cryptic error message Uncaught (in promise) TypeError: this.neighbours[u] is undefined. I would appreciate an update on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants