-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable checkstyle in tmc-netbeans #102
base: master
Are you sure you want to change the base?
Option to disable checkstyle in tmc-netbeans #102
Conversation
This is related to the issue #101 |
WARN, | ||
@SerializedName("fail") | ||
FAIL | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between DISABLED and NONE?
No difference, in some cases none is already used. How does this work if the existing projects have none in some cases and disabled in other cases? |
Should we get rid of one of them then? |
I feel this duplicates existing behaviour, but at least I would not suggest on creating a new undocumented strategy. See https://github.com/testmycode/tmc-checkstyle-runner#options. |
I'm ok with ditching either disabled or none. If the strategy is not found, how is it handled? kasper: do you mean this pull request or the option? |
@avihavai Indeed, this is the issue. Currently Personally, I would make it possible to ask the configuration from |
Any updates on this? |
This is still somewhat relevant. However, I think that the larger issue is that the related dependencies are downloaded with each assignment to the user, making the downloads relatively large at times. I think that we should aim for excluding the dependencies from the download when they are not used or needed. Perhaps something for the legacy project? |
Yep, we shouldn't add unused deps to the project zips when these are generated. However first we need to make sure that the client works w/o having these files. I might put this on hold till we have first deployed version of NB plugin with tmc-core. |
0f9659b
to
8fc669f
Compare
Provides configuration support for disabling checkstyle runs in tmc-netbeans.