Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable checkstyle in tmc-netbeans #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Option to disable checkstyle in tmc-netbeans #102

wants to merge 1 commit into from

Conversation

avihavai
Copy link

Provides configuration support for disabling checkstyle runs in tmc-netbeans.

@avihavai avihavai changed the title #101 option to disable checkstyle in tmc-netbeans Option to disable checkstyle in tmc-netbeans Feb 18, 2015
@avihavai
Copy link
Author

This is related to the issue #101

WARN,
@SerializedName("fail")
FAIL
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between DISABLED and NONE?

@avihavai
Copy link
Author

No difference, in some cases none is already used. How does this work if the existing projects have none in some cases and disabled in other cases?

@mpartel
Copy link
Member

mpartel commented Feb 20, 2015

Should we get rid of one of them then?

@kasper
Copy link
Contributor

kasper commented Mar 2, 2015

I feel this duplicates existing behaviour, but at least I would not suggest on creating a new undocumented strategy. See https://github.com/testmycode/tmc-checkstyle-runner#options.

@avihavai
Copy link
Author

avihavai commented Mar 2, 2015

I'm ok with ditching either disabled or none. If the strategy is not found, how is it handled?

kasper: do you mean this pull request or the option?

@kasper
Copy link
Contributor

kasper commented Mar 2, 2015

@avihavai Indeed, this is the issue. Currently tmc-checkstyle-runner is responsible for reading the configuration and adjusting its behaviour accordingly.

Personally, I would make it possible to ask the configuration from tmc-checkstyle-runner. It currently takes care of deciding the strategy and if it should be run or not. Alternatively, you could move this task completely to this project and the pass the option to the runner. Then again, it would be rather tied to this Netbeans-plugin since the idea is that the runner can be used independently.

@jamo
Copy link
Member

jamo commented Mar 22, 2015

Any updates on this?

@avihavai
Copy link
Author

This is still somewhat relevant. However, I think that the larger issue is that the related dependencies are downloaded with each assignment to the user, making the downloads relatively large at times. I think that we should aim for excluding the dependencies from the download when they are not used or needed. Perhaps something for the legacy project?

@jamo
Copy link
Member

jamo commented Sep 13, 2015

Yep, we shouldn't add unused deps to the project zips when these are generated. However first we need to make sure that the client works w/o having these files.

I might put this on hold till we have first deployed version of NB plugin with tmc-core.

@jamo jamo force-pushed the master branch 2 times, most recently from 0f9659b to 8fc669f Compare March 6, 2016 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants