Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether Exercise#{isReturnable, setReturnable} are used #114

Closed
nygrenh opened this issue Oct 5, 2016 · 5 comments
Closed

Investigate whether Exercise#{isReturnable, setReturnable} are used #114

nygrenh opened this issue Oct 5, 2016 · 5 comments

Comments

@nygrenh
Copy link
Member

nygrenh commented Oct 5, 2016

No description provided.

@jamo
Copy link
Member

jamo commented Oct 5, 2016

https://github.com/testmycode/tmc-netbeans/blob/core/tmc-plugin/src/fi/helsinki/cs/tmc/actions/AbstractExerciseSensitiveAction.java#L75

@nygrenh
Copy link
Member Author

nygrenh commented Oct 5, 2016

Strange, somehow ''Find usages' in Netbeans failed to find that.

@Rochet2
Copy link
Member

Rochet2 commented Oct 5, 2016 •
edited
Loading

Actually it seems tmc-core does not use either of them. Jamox's link is to some other repo.
And in that repo it seems setReturnable is not used even if isReturnable is used.

So things that use tmc-core use the functions?

@jamo
Copy link
Member

jamo commented Oct 5, 2016 •
edited
Loading

the setter is either for gson deserialization or for testing (tho latter could be achieved just fine with mockito)

@nygrenh
Copy link
Member Author

nygrenh commented Oct 5, 2016

@Rochet2 No, I searched for both of the methods :).

@nygrenh nygrenh closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rochet2 @jamo @nygrenh