Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climate missing override parameter? #310

Open
stx opened this issue Sep 9, 2024 · 3 comments
Open

Climate missing override parameter? #310

stx opened this issue Sep 9, 2024 · 3 comments

Comments

@stx
Copy link

stx commented Sep 9, 2024

When you start the climate in the Tesla app with a door open it prompts for an override. Presumably using the same manual_override parameter that exists in other commands like Defrost?

That override is present on some commands in the SDK but is missing here:

func (v *Vehicle) ClimateOn(ctx context.Context) error {

@zhy2020
Copy link

zhy2020 commented Sep 13, 2024

Hello, can I control the air conditioner through ble? I look at the code as if it is calling the Internet method

@sethterashima
Copy link
Collaborator

@stx The Manual Override bool is defined in the protobuf built by the method you linked: https://github.com/teslamotors/vehicle-command/blob/main/pkg/protocol/protobuf/car_server.proto#L142. Be careful about setting it to true; IIRC, it also overrides dog mode and low SoC, and so, as the name suggests, should never be set automatically without explicit manual confirmation.

There's a pending PR that will likely conflict with a quick fix, so I'd prefer to wait it gets merged.

@zhy2020 Please keep comments on topic. The example BLE program shows how to accomplish what you're after.

@stx
Copy link
Author

stx commented Sep 16, 2024

@stx The Manual Override bool is defined in the protobuf built by the method you linked: https://github.com/teslamotors/vehicle-command/blob/main/pkg/protocol/protobuf/car_server.proto#L142. Be careful about setting it to true; IIRC, it also overrides dog mode and low SoC, and so, as the name suggests, should never be set automatically without explicit manual confirmation.

There's a pending PR that will likely conflict with a quick fix, so I'd prefer to wait it gets merged.

@zhy2020 Please keep comments on topic. The example BLE program shows how to accomplish what you're after.

Makes total sense. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants