Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Give SNS feedback access to CloudWatch #237

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aldenquimby
Copy link

Description

  • The SNS feedback role needs both (a) allow SNS to assume the role, and (b) allow writing to CloudWatch
  • This PR adds (b)

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

iam.tf Outdated Show resolved Hide resolved
@aldenquimby aldenquimby changed the title fix: give SNS feedback access to CloudWatch fix: Give SNS feedback access to CloudWatch Sep 20, 2024
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 21, 2024
@aldenquimby
Copy link
Author

This is still valid. Commenting to keep it open

@github-actions github-actions bot removed the stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNS Feedback role is broken
2 participants