fix: Update aws_sns_topic_subscription endpoint to use qualified arn
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `aws_sns_topic_subscription` resource to use the `lambda_function_qualified_arn` output for the `endpoint` value. Also bump the `lambda` module to `6.8.0`, which is the latest version that maintains compatability with `aws` v4 provider. Fixes: terraform-aws-modules#230
1 task
bryantbiggs
approved these changes
Sep 3, 2024
|
This PR is included in version 6.4.1 🎉 |
gdacunda
pushed a commit
to zype/terraform-aws-notify-slack
that referenced
this pull request
Oct 3, 2024
…raform-aws-notify-slack into INF-2667 * 'master' of https://github.com/terraform-aws-modules/terraform-aws-notify-slack: chore(release): version 6.5.0 [skip ci] feat: Add variable to allow disabling the package timestamp trigger (terraform-aws-modules#233) chore(release): version 6.4.1 [skip ci] fix: Update `aws_sns_topic_subscription` endpoint to use qualified arn (terraform-aws-modules#231) chore(release): version 6.4.0 [skip ci] feat: Improved AWS backup notification readability (terraform-aws-modules#222) chore(release): version 6.3.0 [skip ci] feat: Update Python lambda runtime from `3.8` to `3.11` (terraform-aws-modules#225) chore(release): version 6.2.0 [skip ci] feat: Added architecture variable (terraform-aws-modules#224) chore(release): version 6.1.2 [skip ci] fix: Correct assume role permissions for SNS service to assume IAM role (terraform-aws-modules#220) chore(release): version 6.1.1 [skip ci] fix: Update CI workflow versions to remove deprecated runtime warnings (terraform-aws-modules#218)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit updates the
aws_sns_topic_subscriptionresource to use thelambda_function_qualified_arnoutput for theendpointvalue.Also bump the
lambdamodule to6.8.0, which is the latest version that maintains compatability withawsv4 provider.Motivation and Context
Fixes: #230
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request