From e95cde8acdaf221e74595daa2238b75f0682ea06 Mon Sep 17 00:00:00 2001 From: Gavin Williams Date: Tue, 3 Sep 2024 15:13:40 +0100 Subject: [PATCH] fix: Update `aws_sns_topic_subscription` endpoint to use qualified arn (#231) This commit updates the `aws_sns_topic_subscription` resource to use the `lambda_function_qualified_arn` output for the `endpoint` value. Also bump the `lambda` module to `6.8.0`, which is the latest version that maintains compatability with `aws` v4 provider. Fixes: #230 --- README.md | 2 +- main.tf | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index b08169f3..8da63311 100644 --- a/README.md +++ b/README.md @@ -76,7 +76,7 @@ See the [functions](https://github.com/terraform-aws-modules/terraform-aws-notif | Name | Source | Version | |------|--------|---------| -| [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 3.2.0 | +| [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 6.8.0 | ## Resources diff --git a/main.tf b/main.tf index c8587fad..f533456c 100644 --- a/main.tf +++ b/main.tf @@ -73,14 +73,14 @@ resource "aws_sns_topic_subscription" "sns_notify_slack" { topic_arn = local.sns_topic_arn protocol = "lambda" - endpoint = module.lambda.lambda_function_arn + endpoint = module.lambda.lambda_function_qualified_arn filter_policy = var.subscription_filter_policy filter_policy_scope = var.subscription_filter_policy_scope } module "lambda" { source = "terraform-aws-modules/lambda/aws" - version = "3.2.0" + version = "6.8.0" create = var.create