Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document.createElement bug #6

Open
Jamtis opened this issue May 18, 2013 · 3 comments
Open

document.createElement bug #6

Jamtis opened this issue May 18, 2013 · 3 comments

Comments

@Jamtis
Copy link

Jamtis commented May 18, 2013

Hi, I always get an error in IE8 in shivedCreateElement function (https://github.com/termi/ES5-DOM-SHIM/blob/0.7/__SRC/a.ie8.js, l:2115) saying that this["orig__createElement"] is null.
I changed this["orig__createElement"] to document["orig__createElement"] and now it works for me.

@termi
Copy link
Owner

termi commented May 20, 2013

Thanks you.
I will fix it soon with new major version on this lib. I am testing new version right now.

@Jamtis
Copy link
Author

Jamtis commented May 20, 2013

Nice.
I really like this shim!
Maybe you could add a.ie8.js and a.ielt8.js dynamically as modules, that would avoid the need of adding two or three <script> tags.

@termi
Copy link
Owner

termi commented May 24, 2013

Good point. I will consider that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants