Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmi backport #16

Open
przemyslaw opened this issue Jun 5, 2024 · 1 comment
Open

wasmi backport #16

przemyslaw opened this issue Jun 5, 2024 · 1 comment
Assignees

Comments

@przemyslaw
Copy link
Collaborator

przemyslaw commented Jun 5, 2024

Newer rust nightly toolchains emit sign extenesion opcodes by default and we currently don’t support these.

The thing here is to try to backport this PR wasmi-labs/wasmi#360 onto our fork https://github.com/casper-network/casper-wasmi

Some context: we’ve forked wasmi 0.13.2 (used to be considered ‘rock solid’ release and used by polkadot for a very long time) which is last release before they started to break APIs. There’s a lot of effort involved to use upstream wasmi due to many API changes, so we have this fork on life support. There were some security fixes as well. But it lacks some features that are getting more common in the compilers (i.e. sign ext, bulk memory). We’ve figured with Karan it may be worthwile to give it a shot and backport said PR ontop of our fork and see what happens. If we succeed it’s great, we don’t need to worry about compilers using “fancy” wasm extensions by default, otherwise if it takes more than day or two we may as well wait for new engine with different VM

@filipslezaklab filipslezaklab self-assigned this Jul 4, 2024
@wojcik91
Copy link

casper-wasmi already includes this PR, but sign extension support is not actually enabled.
To enable it add sign_ext feature to casper-wasm import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants